Add a public parser which returns hcl.Diagnostics to make life easier for community tooling (LSP) #20026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for community tooling (LSP)
|
|
jrasell
reviewed
Feb 23, 2024
There was a problem hiding this comment.
Hi @anthonymq and thanks for raising this PR. I've taken a quick initial pass through the changes and I think it would be better to have the decode function return a single object of hcl.Diagnostics rather than two objects such as return diags, diags. The callers can then handle whether to keep the original object type, or convert this to an error.
|
Hi @jrasell, thanks for the response. I made the change. Makes sense. |
tgross
added
the
stage/needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm building a Nomad LSP and It would be super useful for this kind of community tooling if you could expose a parser which returns hcl.Diagnostics.
Here is a PR that add this public method without breaking changes.
Let me know if you need some changes.
Thanks