Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifications to get remote-content to fetch versionless docs #2642

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Modifications to get remote-content to fetch versionless docs #2642

merged 3 commits into from
Dec 3, 2024

Conversation

heatlikeheatwave
Copy link
Collaborator

@heatlikeheatwave heatlikeheatwave commented Nov 29, 2024 •
edited
Loading

🔗 Relevant links

🗒️ What

  • Changes to make sure that docs pages will load with the UDR API change to allow for versionless docs. UDR PR here

🧪 Testing

  1. Check out this branch
git checkout heat/versionless-docs
  1. Visit deployment page here. Copy the deployment URL
  2. Update env file
UNIFIED_DOCS_API=<deployment-url>
HASHI_ENV="unified-docs-sandbox"
  1. Start application
npm run start
  1. Visit your local HCP Terraform page here. See that it renders as expected.
  2. Visit your local Terraform Enterprise page here. See that it renders as expected

@vercel Vercel
Copy link

vercel bot commented Nov 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 8:49pm

@heatlikeheatwave heatlikeheatwave self-assigned this Nov 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

RubenSandwich
RubenSandwich approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@RubenSandwich RubenSandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merge it. 👍🏻

@heatlikeheatwave heatlikeheatwave merged commit 04e040d into main Dec 3, 2024
9 checks passed
@heatlikeheatwave heatlikeheatwave deleted the heat/versionless-docs branch December 3, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubenSandwich RubenSandwich Awaiting requested review from RubenSandwich

Assignees

@heatlikeheatwave heatlikeheatwave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heatlikeheatwave @RubenSandwich