-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] add demo migrations to OpenApiDocsViewV2 #2624
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action π€ New Page AddedThe following page was added to the bundle from the code in this PR:
Eight Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
72feb84
to
0e55a97
Compare
7d8525e
to
fad1f9b
Compare
fad1f9b
to
a5f90e9
Compare
a5f90e9
to
99047a6
Compare
5e2eb4a
to
98c1e19
Compare
99047a6
to
f94dc22
Compare
f94dc22
to
c12fba6
Compare
85abbe2
to
d3b67be
Compare
d3b67be
to
6ebeb1f
Compare
edf4b07
to
2cb1e15
Compare
2cb1e15
to
d318a79
Compare
1866c92
to
5a81935
Compare
Previously used for /boundary/api-docs. Version alert component localized into views/open-api-docs-view.
5a81935
to
0bc7060
Compare
Warning
This PR is not meant to be merged. It's meant as a reference of the remaining work to be done to migrate to our new OpenAPI docs template.
π Relevant links
ποΈ What
This PR demos the migration work needed to move to our new OpenAPI docs view, which splits operations to individual pages.
One way to move the migration work forward would be to take each individual commit on this branch, and split it out to a separate PR. Each of these PRs could be worked on and then merged to
main
in the original commit order.To get more specific, each of the following commits could be split to a separate PR. Each of these could be framed as a separate task, though there are definitely some dependencies here to be aware of. I've tried my best to think about these dependencies and note them below.
main
first, then this commit could be droppedπ€· Why
To provide a reference for the remaining work to be done to migrate to our new OpenAPI docs template.
πΈ Design Screenshots
/hcp/api-docs/vault-secrets
HCP Vault Secrets is the first set of OpenAPI docs we expect to migrate to our new template. We have a PR up here:
Note
The landing page is a little empty, due to the short
description
that HCP Vault Secrets has set in its spec (ref). See the HCP Consul and Boundary examples below for longer descriptions, with full markdown support./boundary/api-docs
The upstream Boundary API docs use an even older OpenAPI template (the first one we ever implemented!). It'll be a bit of a jump to go straight to our newest template, hopefully in a good way.
/hcp/api-docs/consul
Note
Consul has been included as an example of an HCP use of the new template that has more specific needs. In Consul's case, authors want to omit a specific versions of the OpenAPI spec, despite that file being available in the source
hashicorp/hcp-specs
repo. We've implemented a shim that handles this in the page file for the HCP Consul API specs./hcp/api-docs/identity
/hcp/api-docs/packer
/hcp/api-docs/vagrant-box-registry
/hcp/api-docs/waypoint
/hcp/api-docs/webhook
π§ͺ Testing
Review the migrated pages. Each page should provide an experience that's equivalent to the upstream page. Of course, the migrated pages have their operations split to separate URLs. As well, the sidebar filter has been intentionally omitted, per ποΈ Remove sidebar filtering, redundant with global search.
The preview tool has also been shifted to the previously used URL, since
V2
will no longer be a helpful identifier once we've fully deprecated the old version of the preview toolπ Anything else?
We have a parallel PR that adds the net-new OpenAPI docs for HCP RBAC. There's a bit of duplicative work in that PR, if it merges to main first, then we'll have already shipped the
getOperationTitle
feature.