-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump code-block for complex snippet copy #2450
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action π€ Sixty-four Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
package.json
Outdated
@@ -110,7 +110,7 @@ | |||
"@hashicorp/react-code-block": "^6.6.0", | |||
"@hashicorp/react-consent-manager": "^9.2.0", | |||
"@hashicorp/react-content": "^8.3.0", | |||
"@hashicorp/react-design-system-components": "^0.0.0-nightly.0c364f3", | |||
"@hashicorp/react-design-system-components": "^0.0.0-nightly.c797020", | |||
"@hashicorp/react-design-system-tokens": "^0.0.0-nightly.8920560", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zchsh can you bump react-design-system-tokens
to the same version? There's nothing new, but I want to make sure we keep the versions aligned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great call - done! β
Converting back to draft, need to wrap up web#1546 - fix: shellwords import first, then will merge that, and bump the deps here again π |
π Relevant links
ποΈ What
Bumps
@hashicorp/react-design-system-components
to pull in copy-snippets revisions from https://github.com/hashicorp/web/pull/1537.πΈ Design Screenshots
π§ͺ Testing
shell-session
snippet$
character should be omittedπ Anything else?
@hashicorp/react-design-system-tokens
to keep it in lockstep with-components