Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump code-block for complex snippet copy #2450

Merged
merged 7 commits into from
May 16, 2024

Conversation

zchsh
Copy link
Contributor

@zchsh zchsh commented May 15, 2024

πŸ”— Relevant links

πŸ—’οΈ What

Bumps @hashicorp/react-design-system-components to pull in copy-snippets revisions from https://github.com/hashicorp/web/pull/1537.

πŸ“Έ Design Screenshots

Before After
before after

πŸ§ͺ Testing

πŸ’­ Anything else?

  • Bumps @hashicorp/react-design-system-tokens to keep it in lockstep with -components
  • Pins the aforementioned deps to exact versions

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
dev-portal βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 16, 2024 8:14pm

Copy link

github-actions bot commented May 15, 2024

πŸ“¦ Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action πŸ€–

Sixty-four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[productSlug]/docs 182.18 KB (🟑 +605 B) 392.54 KB
/[productSlug]/integrations/[organizationSlug]/[integrationSlug] 179.2 KB (🟑 +605 B) 389.57 KB
/[productSlug]/integrations/[organizationSlug]/[integrationSlug]/[integrationVersion] 179.21 KB (🟑 +605 B) 389.57 KB
/[productSlug]/integrations/[organizationSlug]/[integrationSlug]/[integrationVersion]/components/[componentType]/[componentSlug] 185.08 KB (🟑 +606 B) 395.45 KB
/[productSlug]/tutorials/[...tutorialSlug] 211.06 KB (🟑 +623 B) 421.43 KB
/boundary/api-docs/[[...page]] 183.17 KB (🟑 +605 B) 393.53 KB
/boundary/docs/[...page] 180.23 KB (🟑 +605 B) 390.59 KB
/boundary/install 186.11 KB (🟑 +616 B) 396.48 KB
/certifications 180.78 KB (🟑 +621 B) 391.15 KB
/certifications/[slug] 181.43 KB (🟑 +621 B) 391.79 KB
/consul/api-docs/[[...page]] 180.23 KB (🟑 +605 B) 390.6 KB
/consul/commands/[[...page]] 180.23 KB (🟑 +606 B) 390.59 KB
/consul/docs/[...page] 180.22 KB (🟑 +606 B) 390.59 KB
/consul/install 180.02 KB (🟑 +616 B) 390.39 KB
/consul/install/enterprise 180.06 KB (🟑 +616 B) 390.43 KB
/hcp/api-docs/consul/[[...page]] 171.22 KB (🟑 +622 B) 381.58 KB
/hcp/api-docs/packer/[[...page]] 171.22 KB (🟑 +620 B) 381.58 KB
/hcp/api-docs/vault-secrets/[[...page]] 171.22 KB (🟑 +621 B) 381.59 KB
/hcp/api-docs/webhook/[[...page]] 171.22 KB (🟑 +621 B) 381.58 KB
/hcp/docs/[...page] 180.22 KB (🟑 +605 B) 390.59 KB
/nomad/api-docs/[[...page]] 180.23 KB (🟑 +605 B) 390.6 KB
/nomad/docs/[...page] 180.22 KB (🟑 +605 B) 390.59 KB
/nomad/install 179.38 KB (🟑 +616 B) 389.74 KB
/nomad/install/enterprise 179.36 KB (🟑 +616 B) 389.73 KB
/nomad/intro/[[...page]] 180.23 KB (🟑 +605 B) 390.59 KB
/nomad/plugins/[[...page]] 180.23 KB (🟑 +605 B) 390.59 KB
/nomad/tools/[[...page]] 180.23 KB (🟑 +605 B) 390.59 KB
/onboarding/[...tutorialSlug] 199.84 KB (🟑 +622 B) 410.21 KB
/open-api-docs-preview 175.66 KB (🟑 +621 B) 386.03 KB
/packer/docs/[...page] 180.22 KB (🟑 +605 B) 390.59 KB
/packer/guides/[[...page]] 180.23 KB (🟑 +605 B) 390.59 KB
/packer/install 179.35 KB (🟑 +616 B) 389.72 KB
/sentinel/docs/[[...page]] 180.23 KB (🟑 +606 B) 390.59 KB
/sentinel/install 179.36 KB (🟑 +616 B) 389.72 KB
/sentinel/intro/[[...page]] 180.23 KB (🟑 +605 B) 390.59 KB
/terraform/cdktf/[[...page]] 180.23 KB (🟑 +605 B) 390.6 KB
/terraform/cli/[[...page]] 180.23 KB (🟑 +605 B) 390.59 KB
/terraform/cloud-docs/[[...page]] 180.23 KB (🟑 +605 B) 390.6 KB
/terraform/cloud-docs/agents/[[...page]] 180.24 KB (🟑 +605 B) 390.6 KB
/terraform/docs/[...page] 180.23 KB (🟑 +605 B) 390.59 KB
/terraform/enterprise/[[...page]] 180.23 KB (🟑 +605 B) 390.6 KB
/terraform/install 179.36 KB (🟑 +616 B) 389.72 KB
/terraform/internals/[[...page]] 180.23 KB (🟑 +606 B) 390.6 KB
/terraform/intro/[[...page]] 180.23 KB (🟑 +605 B) 390.6 KB
/terraform/language/[[...page]] 180.23 KB (🟑 +605 B) 390.6 KB
/terraform/plugin/[[...page]] 180.23 KB (🟑 +605 B) 390.6 KB
/terraform/plugin/framework/[[...page]] 180.24 KB (🟑 +605 B) 390.6 KB
/terraform/plugin/log/[[...page]] 180.23 KB (🟑 +606 B) 390.6 KB
/terraform/plugin/mux/[[...page]] 180.23 KB (🟑 +605 B) 390.6 KB
/terraform/plugin/sdkv2/[[...page]] 180.23 KB (🟑 +605 B) 390.6 KB
/terraform/plugin/testing/[[...page]] 180.24 KB (🟑 +605 B) 390.6 KB
/terraform/registry/[[...page]] 180.23 KB (🟑 +605 B) 390.6 KB
/vagrant/docs/[...page] 180.23 KB (🟑 +605 B) 390.59 KB
/vagrant/install 179.98 KB (🟑 +616 B) 390.35 KB
/vagrant/install/vmware 179.36 KB (🟑 +616 B) 389.73 KB
/vagrant/intro/[[...page]] 180.23 KB (🟑 +606 B) 390.59 KB
/vagrant/vagrant-cloud/[[...page]] 180.23 KB (🟑 +605 B) 390.6 KB
/validated-designs/[...slug] 177.86 KB (🟑 +622 B) 388.23 KB
/vault/api-docs/[[...page]] 180.23 KB (🟑 +606 B) 390.59 KB
/vault/docs/[...page] 180.22 KB (🟑 +605 B) 390.59 KB
/vault/install 179.35 KB (🟑 +616 B) 389.72 KB
/vault/install/enterprise 179.36 KB (🟑 +616 B) 389.72 KB
/waypoint/docs/[...page] 180.22 KB (🟑 +605 B) 390.59 KB
/well-architected-framework/[...tutorialSlug] 200.06 KB (🟑 +623 B) 410.42 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

package.json Outdated
@@ -110,7 +110,7 @@
"@hashicorp/react-code-block": "^6.6.0",
"@hashicorp/react-consent-manager": "^9.2.0",
"@hashicorp/react-content": "^8.3.0",
"@hashicorp/react-design-system-components": "^0.0.0-nightly.0c364f3",
"@hashicorp/react-design-system-components": "^0.0.0-nightly.c797020",
"@hashicorp/react-design-system-tokens": "^0.0.0-nightly.8920560",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zchsh can you bump react-design-system-tokens to the same version? There's nothing new, but I want to make sure we keep the versions aligned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great call - done! βœ…

@zchsh zchsh marked this pull request as ready for review May 16, 2024 18:37
@zchsh zchsh requested review from a team and rmainwork and removed request for a team May 16, 2024 18:37
@zchsh zchsh marked this pull request as draft May 16, 2024 19:33
@zchsh
Copy link
Contributor Author

zchsh commented May 16, 2024

Converting back to draft, need to wrap up web#1546 - fix: shellwords import first, then will merge that, and bump the deps here again πŸ‘

@zchsh zchsh marked this pull request as ready for review May 16, 2024 20:08
@zchsh zchsh merged commit d9004d6 into main May 16, 2024
9 checks passed
@zchsh zchsh deleted the zs.bump-code-block-for-snippet-copy branch May 16, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants