Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on typechecking for text component template in showcase #2107

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

natmegs
Copy link
Contributor

@natmegs natmegs commented May 16, 2024

πŸ“Œ Summary

Example of how we can use showcase to check types as a consumer for HDS components. This PR opts into template typechecking for the Text component, and similar opt in could be done for showcase templates displaying any typed HDS components.

2 issues preventing this from being merged:

  • Currently there are type failures in the text template since the type of this.model is void, even though route and controller are typed. I must be missing something as these docs indicate the type should be inferred based on route + controller
  • Using glint-expect-error to get around the above results in CLI output saying the expect error is unnecessary, but removing it results in a legit type error

πŸ› οΈ Detailed description

πŸ“Έ Screenshots

πŸ”— External links

Jira ticket: HDS-XXX
Figma file: [if it applies]


πŸ‘€ Component checklist

πŸ’¬ Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
hds-showcase βœ… Ready (Inspect) Visit Preview May 16, 2024 6:34pm
hds-website βœ… Ready (Inspect) Visit Preview May 16, 2024 6:34pm

@didoo
Copy link
Contributor

didoo commented May 22, 2024

@natmegs now that @aklkv PR #2109 has been merged, I think this draft PR can be closed right? (they do the same thing if I'm not wrong).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants