Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PopoverPrimitive - Convert to TypeScript #2105

Draft
wants to merge 4 commits into
base: hds-anchored-position-ts-conversion
Choose a base branch
from

Conversation

didoo
Copy link
Contributor

@didoo didoo commented May 16, 2024

πŸ“Œ Summary

❌ Currently it doesn't compile because of an error I need to investigate ❌

Converts PopoverPrimitive to TypeScript.

Depends on #2103 and #2104.

πŸ”— External links

Jira ticket: https://hashicorp.atlassian.net/browse/HDS-3339


πŸ‘€ Component checklist

πŸ’¬ Please consider using conventional comments when reviewing this PR.

@didoo didoo requested a review from a team May 16, 2024 15:02
Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
hds-showcase ❌ Failed (Inspect) May 22, 2024 11:37am
hds-website ❌ Failed (Inspect) May 22, 2024 11:37am

@didoo didoo changed the base branch from main to hds-anchored-position-ts-conversion May 16, 2024 15:03
@didoo didoo mentioned this pull request May 16, 2024
2 tasks
@didoo didoo force-pushed the hds-anchored-position-ts-conversion branch 2 times, most recently from 8677479 to 3c86721 Compare May 16, 2024 17:03
@didoo didoo force-pushed the popover-primitive-ts-conversion branch from 4e2735f to 911f066 Compare May 16, 2024 20:28
@didoo didoo force-pushed the popover-primitive-ts-conversion branch from 911f066 to af0e267 Compare May 16, 2024 20:56
@didoo didoo force-pushed the popover-primitive-ts-conversion branch from af0e267 to 343010b Compare May 17, 2024 07:39
@didoo didoo force-pushed the hds-anchored-position-ts-conversion branch 2 times, most recently from b5be7e8 to e5d8530 Compare May 17, 2024 17:14
@didoo didoo force-pushed the popover-primitive-ts-conversion branch from 343010b to 7ab0979 Compare May 20, 2024 12:18
@didoo didoo force-pushed the hds-anchored-position-ts-conversion branch 5 times, most recently from 0b05d35 to f8e0fe1 Compare May 21, 2024 22:17
@didoo didoo force-pushed the popover-primitive-ts-conversion branch from 7ab0979 to aca2108 Compare May 21, 2024 22:21
@didoo didoo force-pushed the hds-anchored-position-ts-conversion branch from f8e0fe1 to 22a46eb Compare May 22, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants