Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidenav - Convert to TypeScript #2102

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

Sidenav - Convert to TypeScript #2102

wants to merge 24 commits into from

Conversation

didoo
Copy link
Contributor

@didoo didoo commented May 16, 2024

📌 Summary

🚨 Still a work in progress 🚨

Converts the SideNav component and subcomponents to TypeScript.

🔗 External links

Jira ticket: https://hashicorp.atlassian.net/browse/HDS-2711

👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@didoo didoo requested a review from a team May 16, 2024 13:53
@vercel Vercel
Copy link

vercel bot commented May 16, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ❌ Failed (Inspect) May 22, 2024 11:37am
hds-website ❌ Failed (Inspect) May 22, 2024 11:37am

@didoo didoo marked this pull request as draft May 16, 2024 13:53
@hashibot-hds hashibot-hds added packages/components docs-website Content updates to the documentation website labels May 16, 2024
didoo and others added 24 commits May 22, 2024 12:24
@didoo
renamed js files to ts
8acc875
@didoo
removed glint-nocheck declaration in template files
3b0c28f
@didoo
run command `npx ember-codemod-args-to-signature --src src/components…
dc188bb 
…/hds/side-nav`
@didoo
bumped version of ember-stargate to 0.5.0 (Glint 1.0 support)
1fb1ac2
@didoo
added types for @ember/destroyable to dependencies
4b1aff6
@didoo
converted SideNav::Header::HomeLink component to TS
9a4070a
@didoo
converted SideNav::Header::IconButton component to TS
801315c
@didoo
converted SideNav::Header component to TS
0f16446
@didoo
converted SideNav::List::BackLink component to TS
a8e2c72
@didoo
converted SideNav::List::Item component to TS
7d88c9a
@didoo
converted SideNav::List::Link component to TS
57371f2
@didoo
converted SideNav::List::Title component to TS
c06ca63
@didoo
fully converted SideNav::List component to TS
25bf62c
@didoo
converted SideNav::Portal component to TS
439a4cf
@didoo
converted SideNav::Portal::Target component to TS
f7d4a1b
@didoo
converted SideNav::ToggleButton component to TS
a94e4ea
@didoo
converted SideNav::Base component to TS
f5c08ab
@didoo
converted SideNav component to TS
e5c5e4e
@didoo
updated backing classes to use the new TemplateOnlyComponent with s…
0601bbf 
…ignature
@didoo
fixed TS complaining about this.constructor
d3effef
@aklkv @didoo
fix: template-registry
d6407ab
@didoo
re-ordered imports in `packages/components/unpublished-development-ty…
e1a3693 
…pes/global.d.ts`
@didoo
added two @glint-expect-error in the SideNav template file for co…
d3027ab 
…mponent and modifier that don’t have types exposed
@didoo
updated imported registry name
fff2465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs-website Content updates to the documentation website packages/components typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@didoo @hashibot-hds @aklkv