CopyButton: convert to TypeScript (HDS-2688)
#2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KristinLBradley
commented
May 15, 2024
KristinLBradley
commented
May 15, 2024
KristinLBradley
commented
May 15, 2024
KristinLBradley
commented
May 15, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
KristinLBradley
commented
May 16, 2024
This comment was marked as outdated.
This comment was marked as outdated.
1 task
Co-authored-by: Alex <[email protected]>
Co-authored-by: Cristiano Rastelli <[email protected]>
Co-authored-by: Cristiano Rastelli <[email protected]>
Co-authored-by: Cristiano Rastelli <[email protected]>
KristinLBradley
force-pushed
the
hds-2688-copy-button-ts-conversion
branch
from
a89bb3e
to
72e40ea
Compare
|
@alex-ju Does this one look ok to merge now? |
alex-ju
approved these changes
May 24, 2024
Co-authored-by: Cristiano Rastelli <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR converts the
CopyButtonto TypeScript.The CopyButton depends upon:
hds-clipboardmodifier: convert to TypeScript (HDS-3344) #2120🔗 External links
👀 Component checklist
[ ] Percy was checked for any visual regression💬 Please consider using conventional comments when reviewing this PR.