AppFrame - Convert to TypeScript
#2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alex-ju
reviewed
May 16, 2024
alex-ju
approved these changes
May 17, 2024
| Blocks: { | ||
| default: []; | ||
| }; | ||
| Element: HTMLElement; |
There was a problem hiding this comment.
Noting here that there is no HTMLFooterElement that we could use, unfortunately.
MelSumner
force-pushed
the
melsumner/hds-2719-appframe-ts
branch
from
8d15d4b
to
e831d65
Compare
Co-authored-by: Alex <[email protected]>
MelSumner
force-pushed
the
melsumner/hds-2719-appframe-ts
branch
from
ba12a3e
to
a32efcd
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR converts the AppFrame component (and sub-components) to TypeScript.
🔗 External links
Jira ticket: HDS-2719
💬 Please consider using conventional comments when reviewing this PR.