AppFooter - Convert to Typescript
#2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dhaulagiri
force-pushed
the
br-app-footer-ts
branch
from
f2fa907
to
a56c548
Compare
Dhaulagiri
force-pushed
the
br-app-footer-ts
branch
from
a56c548
to
fc44fb3
Compare
alex-ju
reviewed
May 16, 2024
packages/components/src/components/hds/app-footer/status-link.ts
Outdated
Show resolved
Hide resolved
Dhaulagiri
force-pushed
the
br-app-footer-ts
branch
from
e0c98ae
to
764a215
Compare
Dhaulagiri
force-pushed
the
br-app-footer-ts
branch
from
764a215
to
041126d
Compare
Dhaulagiri
commented
May 16, 2024
packages/components/src/components/hds/app-footer/status-link.ts
Outdated
Show resolved
Hide resolved
Dhaulagiri
commented
May 16, 2024
Dhaulagiri
force-pushed
the
br-app-footer-ts
branch
from
e5bd029
to
906c7cb
Compare
|
Once #2108 lands I'll make similar adjustments here, but for now it'd be good to get more feedback on everything else besides those details |
Dhaulagiri
commented
May 16, 2024
Argument of type 'string | undefined' is not assignable to parameter of type 'string'. Type 'undefined' is not assignable to type 'string'.ts(2345)
Co-authored-by: Cristiano Rastelli <[email protected]>
Dhaulagiri
force-pushed
the
br-app-footer-ts
branch
from
87dcc3a
to
4ec78de
Compare
Dhaulagiri
force-pushed
the
br-app-footer-ts
branch
from
4ec78de
to
f6a8424
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Converts the
AppFootercomponent to TS🔗 External links
Jira ticket: HDS-2682