Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript migration docs #2087

Merged
merged 12 commits into from
May 20, 2024
Merged

Add TypeScript migration docs #2087

merged 12 commits into from
May 20, 2024

Conversation

alex-ju
Copy link
Member

@alex-ju alex-ju commented May 10, 2024

📌 Summary

As discussed during the engineering sync, I'm uploading the notes taken during the kick-off session into our wiki.

🔗 External links

Jira ticket: HDS-3316


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview May 20, 2024 3:33pm
hds-website ✅ Ready (Inspect) Visit Preview May 20, 2024 3:33pm

@alex-ju alex-ju requested a review from a team May 10, 2024 10:17
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments

wiki/TypeScript-Migration.md Outdated Show resolved Hide resolved
wiki/TypeScript-Migration.md Outdated Show resolved Hide resolved
wiki/TypeScript-Migration.md Outdated Show resolved Hide resolved
wiki/TypeScript-Migration.md Outdated Show resolved Hide resolved
wiki/TypeScript-Migration.md Outdated Show resolved Hide resolved
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments (things I noticed while doing a conversion)

wiki/TypeScript-Migration.md Show resolved Hide resolved
wiki/TypeScript-Migration.md Show resolved Hide resolved
wiki/TypeScript-Migration.md Outdated Show resolved Hide resolved
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KristinLBradley KristinLBradley self-requested a review May 15, 2024 21:16
Copy link
Contributor

@KristinLBradley KristinLBradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment with a question otherwise looks good!

@alex-ju
Copy link
Member Author

alex-ju commented May 20, 2024

Hopefully, I covered the discussed items. I'll get them in to have a reference and update as we find it necessary.

@alex-ju alex-ju merged commit 33c2dfe into main May 20, 2024
12 checks passed
@alex-ju alex-ju deleted the alex-ju/add-ts-migration-docs branch May 20, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants