Backport of NET-9143 - sameness group queries in DNS do not respect DefaultForFailover setting and always assume failover behavior into release/1.17.x #21082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/jm/NET-9143/openly-humble-malamute
branch
from
85356f6
to
f2362f3
Compare
github-actions
bot
added
the
type/docs
github-team-consul-core-pr-approver
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21029 to be assessed for backporting due to the inclusion of the label backport/1.17.
The below text is copied from the body of the original PR.
Description
In Enterprise edition, we fixed a bug related to Sameness Groups and these are the docs changes related to it.
DefaultForFailoverdictates whether failover behavior should occur when requesting a service using a sameness group. Mesh currently respects this, however, DNS does not. This allows a caller to request DNS for a service using a sameness group and get failover behavior when member services are unhealthy, even though the sameness group was configured not to do this.Testing & Reproduction steps
Links
PR Checklist
Overview of commits