Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update gha to latest approved tsccr #21061

Merged
merged 3 commits into from May 14, 2024
Merged

build: update gha to latest approved tsccr #21061

merged 3 commits into from May 14, 2024

Conversation

DanStough
Copy link
Member

Description

Updating GitHub action versions to the latest TSCCR approved version. This should address Node16 deprecations.

@DanStough DanStough added pr/no-changelog PR does not need a corresponding .changelog entry backport-inactive/1.15 This release series is longer active. Use backport/ent/1.15. backport-inactive/1.16 This release series is longer active backport-inactive/1.17 This release series is longer active. Use backport/ent/1.17. backport/ent/1.18 Changes are backported to 1.18 ent labels May 7, 2024
@DanStough DanStough requested review from NicoletaPopoviciu and a team May 7, 2024 14:47
@DanStough DanStough requested a review from a team as a code owner May 7, 2024 14:47
@DanStough DanStough requested review from rogermakram and jeanneryan and removed request for a team May 7, 2024 14:47
@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels May 7, 2024
rogermakram
rogermakram reviewed May 8, 2024
View reviewed changes
Copy link

@rogermakram rogermakram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bump from actions/upload-artifact from v3 to v4 has a breaking change which is causing the build failures.

@DanStough
Copy link
Member Author

Waiting to merge this one until ENT merges first.

@DanStough DanStough removed backport-inactive/1.15 This release series is longer active. Use backport/ent/1.15. backport-inactive/1.16 This release series is longer active backport-inactive/1.17 This release series is longer active. Use backport/ent/1.17. labels May 10, 2024
@DanStough DanStough merged commit 94791f7 into main May 14, 2024
88 checks passed
@DanStough DanStough deleted the nicoleta/fix-node16-gha branch May 14, 2024 19:49
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogermakram rogermakram rogermakram left review comments

@NicoletaPopoviciu NicoletaPopoviciu NicoletaPopoviciu approved these changes

@jeanneryan jeanneryan Awaiting requested review from jeanneryan

Assignees
No one assigned
Labels
backport/ent/1.18 Changes are backported to 1.18 ent pr/no-changelog PR does not need a corresponding .changelog entry theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanStough @rogermakram @NicoletaPopoviciu