Skip to content

Prevent excessive logging on health checks sync #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent excessive logging on health checks sync #275

wants to merge 1 commit into from

Conversation

v-rosa
Copy link

@v-rosa v-rosa commented Feb 12, 2025 •
edited
Loading

Changes proposed in this PR:

syncChecks pools the container health check endpoint every 1 second.

In version 0.9.0 it started to log every successful check:

2025-02-12T21:59:19.795Z [INFO] container health check updated in Consul: name=consul-dataplane status=HEALTHY
2025-02-12T21:59:18.767Z [INFO] container health check updated in Consul: name=consul-dataplane status=HEALTHY
2025-02-12T21:59:17.760Z [INFO] container health check updated in Consul: name=consul-dataplane status=HEALTHY
...

This floods our log groups with redundant logs.

Ref: support ticket #157262

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

@v-rosa v-rosa requested a review from a team as a code owner February 12, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@v-rosa