Wait VM becomes getable after triggering restore #1419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
What this PR does / why we need it:
vm_checker.wait_getable
betweenapi_client.backups.restore
andvm_checker.wait_ip_addresses
vm_checker.wait_ip_addresses
callsapi_client.vms.start
in the callback chain and will assert FAIL if target VM does not exist.api_client.backups.restore
needs some time to communicate withbackup-target
to restore VM. So depends on the env., VM instance may not be created immediately.Special notes for your reviewer:
This is a quick fix.
IMO, coder tends to expect function
wait_XXX
does some polling GET, thus some error-prone. To enhance, we may:create_AAA_and_wait_XXX
.Additional documentation or context
Verification
Before (
![image](https://private-user-images.githubusercontent.com/2773781/354612997-b55e4d0f-db19-40f1-8d95-798eaac2e7d4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODc0MDEsIm5iZiI6MTczOTU4NzEwMSwicGF0aCI6Ii8yNzczNzgxLzM1NDYxMjk5Ny1iNTVlNGQwZi1kYjE5LTQwZjEtOGQ5NS03OThlYWFjMmU3ZDQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMDIzODIxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjAxNTlmYTA4ZDJlNjI4ZDhiZDA2NWY3YWNhMGUxZWNiYjU4ZDU1MDJjYjc2YWY0Y2Q2ODQzOTgyYjY3ZDBhMCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.ciS5AIief-DnYpSdYJ8-2wIxsizHiZ5nYJcKz1IxfKE)
harvester-runtests#61
)After (
![image](https://private-user-images.githubusercontent.com/2773781/354612758-6dd429fa-a0cb-46ba-a2d2-1e2c33793158.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODc0MDEsIm5iZiI6MTczOTU4NzEwMSwicGF0aCI6Ii8yNzczNzgxLzM1NDYxMjc1OC02ZGQ0MjlmYS1hMGNiLTQ2YmEtYTJkMi0xZTJjMzM3OTMxNTgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMDIzODIxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Y2ZhYjFjODVlZDc3MGY2OTliZjIxMzE5NzhhNGI3NWRlM2NjZTA5ZjYxMDg0M2U2ZjIwYWMxOGEwZmU2ZDY3YiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.Rii7s4_DUBOzItA6q24Ub-hthrRFFf98L-q368tb9Gk)
harvester-runtests#62
)