Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wipe Disks Improvements (backport #885) #956

Open
wants to merge 2 commits into
base: v1.5
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 10, 2025

Problem:

We introduced a field in Harvester config named wipeDisks which when set ran a script in the installer to iterate over all disk devices visible to the host and wipe them.

This ended up being too aggressive, not to mention not all disks may contain old Harvester installations.

Solution:

PR introduces two new fields in the harvester config wipeDisksList and wipeAllDisks and drops the old wipeDisks introduced in v1.3

There is an extra panel in disk configuration page. The extra panel contains a drop down menu which gets rendered and populated if installer finds additional disks with existing elemental based installations which are not already used in install device or additional data device.

The extra Wipe Disks panels will only be available when there are additional disks visible to the host which have a partition with COS_OEM label and such disk is not already being used in Install Device or Install Data Device.

image

User can also pass these fields via ipxe using the following two new fields

install:
  wipeAllDisks: true

or

install:
  wipeDisksList: 
     - device1
     - device2

wipeAllDisks uses the same logic as the installers Wipe Disks Panel where it will identify additional disks with COS_OEM partition which are not already being used as Install Device or Install Data Device.

Related Issue:
harvester/harvester#6304
harvester/harvester#6533

Test plan:


This is an automatic backport of pull request #885 done by [Mergify](https://mergify.com).

PR introduces two new fields in the harvester config wipeDisksList and
wipeAllDisks and drops the old wipeDisks introduced in v1.3

There is an extra panel in disk configuration page. The extra panel
contains a drop down menu which gets rendered and populated if installer
finds additional disks with existing elemental based installations which
are not already used in install device or additional data device

(cherry picked from commit f2c9e76)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant