feat: add rancher integration for airgapped environment and prime case #694
Conversation
|
|
@FrankYang0529 is there an issue with the change? |
| ## Work with prime Rancher | ||
|
|
||
| The prime Rancher uses different registry. If there is no `CATTLE_AGENT_IMAGE` environment variable, the default value uses `docker.io` as default registry whick makes the Harvester can't get correct rancher-agent image. You need to set the `CATTLE_AGENT_IMAGE` environment variable to the correct registry. |
There was a problem hiding this comment.
our doc doesn't suggest using the docker way to deploy Rancher, does Helm deployment need this?
There was a problem hiding this comment.
Yeah, helm is not different from docker. We still need to provide CATTLE_AGENT_IMAGE.
We can add following arguments to helm install command.
--set 'extraEnv[0].name=CATTLE_AGENT_IMAGE' --set 'extraEnv[0].value=<registry>rancher/rancher-agent:v2.8.10'
There was a problem hiding this comment.
@FrankYang0529 Can you provide the exact code block for the Prime doc? Thank you.
There was a problem hiding this comment.
Hi @jillian-maroket, I think it's better for users to follow Rancher document to install it. For full command, they can reference https://ranchermanager.docs.rancher.com/getting-started/quick-start-guides/deploy-rancher-manager/helm-cli. We may just mention to add arguments --set 'extraEnv[0].name=CATTLE_AGENT_IMAGE' --set 'extraEnv[0].value=<registry>rancher/rancher-agent:v2.8.10' to helm command to solve the issue.
There was a problem hiding this comment.
I have reviewed the text. Please note that I will add the Prime-specific content to the SUSE Virtualization section of the Prime doc.
docs/rancher/rancher-integration.md
Outdated
|
|
||
| The prime Rancher uses different registry. If there is no `CATTLE_AGENT_IMAGE` environment variable, the default value uses `docker.io` as default registry whick makes the Harvester can't get correct rancher-agent image. You need to set the `CATTLE_AGENT_IMAGE` environment variable to the correct registry. | ||
|
|
||
| Example: | ||
| ```bash | ||
| docker run --privileged -d --name=rancher --restart=unless-stopped -p 8080:80 -p 6443:443 -e CATTLE_AGENT_IMAGE=<registry>/rancher/rancher-agent:v2.8.10 <registry>/rancher/rancher:v2.8.10 | ||
| ``` |
There was a problem hiding this comment.
Please remove this section. I will add it to the Prime doc. Here is the proposed text for Prime:
Rancher determines the
rancher-agentimage to be used whenever a Harvester cluster is imported. If the image is not included in the Harvester ISO, it must be pulled from the internet and loaded on each node, or pushed to the Harvester cluster's registry.Rancher Prime uses a dedicated registry, so you must assign that registry as the value of the CATTLE_AGENT_IMAGE environment variable. If you do not assign a value, Harvester is unable to retrieve the correct
rancher-agentimage becausedocker.iois used as the default registry.Example:
docker run --privileged -d --name=rancher --restart=unless-stopped -p 8080:80 -p 6443:443 -e CATTLE_AGENT_IMAGE=<registry>/rancher/rancher-agent:v2.8.10 <registry>/rancher/rancher:v2.8.10
|
@FrankYang0529 and @bk201 I created this PR in the Prime docs repo. Our doc project manager is asking if this applies to Helm-based installations. Please help provide more context. I'm pasting the full review comment here in case you are unable to access the repo.
|
|
@FrankYang0529 please check https://github.com/harvester/docs/pull/694/files#r1895396706 for helm installation |
FrankYang0529
force-pushed
the
airgapped-prime-rancher
branch
from
0d9510a to
ea9114b
Compare
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
force-pushed
the
airgapped-prime-rancher
branch
from
ea9114b to
ec8b3ef
Compare
|
@jillian-maroket thanks for the review and suggestion. I address all comments. 👍 |
No description provided.