-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Project #475
Open
alexmercerind
wants to merge
99
commits into
master
Choose a base branch
from
vnext
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rewrite Project #475
+14,480
−35,816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…letteNotifier, MobileNowPlayingNotifier, DesktopNowPlayingNotifier
can you add builds to actions please i would like to test and give feed back |
Thanks a lot for your interest @ryzendew. You may join our Discord to provide feedback, where I share updates etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
I want to feel satisfied about the project & the work I've done.
I want architecture & implementation to be in a good shape. This calls for a major rewrite (and/or) refactor. The project has been in development for a good amount of time & over the time many compromises have been made:
There are many other reasons as well. During this period, I have also evolved as an engineer & have learnt a lot more about software development in general (now that I'm about to graduate). It's time to put those ideas into practice here as well.