Increase options for tcp services. Add accept-proxy to the list of available parameters with backward compat. #525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At $dayjob we use haproxy on TCP services and we rely on the proxy protocol to transport the remote endpoint ip address to the backends.
Very often we chain several proxies one in front of the other. We noticed that the ingress controller doesn't handle the accept-proxy option, while it is supported for HTTP(s) connections through other settings.
This patch reuses the third parameter of the tcp services list, previously optional and supporting only
ssl
as value and transforms it into a comma separated list of options; It also adds theaccept-proxy
option support.When the tcp service will contain
accept-proxy
in the options, it will be added to the bind line in the configuration file.This should also address several requests and issues, like #318 and should enable more features to be added to the tcp services keeping the backward compatibility.