Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to unnecessary resource version bump on update #6715

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

epeartree
Copy link
Collaborator

@epeartree epeartree commented Feb 14, 2025

Background:
When resource tags are stored in a separate table (HFJ_TAG_DEF), it is possible to have duplicates.

The problem:
When we update a resource that has tags, we lookup the entity tags and return the first tag match. if that match happens to belong to another resource, the entity's tag list is updated which unnecessarily creates a new version of the resource

What was done:

  • added failing test;
  • added utility method to perform logical comparison on tags;
  • added changelog;

Closes #6714

@epeartree epeartree linked an issue Feb 14, 2025 that may be closed by this pull request
Copy link

Formatting check succeeded!

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.57%. Comparing base (78537ba) to head (bd7f16e).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6715      +/-   ##
============================================
- Coverage     83.58%   83.57%   -0.01%     
  Complexity    28650    28650              
============================================
  Files          1798     1798              
  Lines        111363   111376      +13     
  Branches      13982    13983       +1     
============================================
+ Hits          93080    93085       +5     
- Misses        12280    12286       +6     
- Partials       6003     6005       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epeartree epeartree merged commit 57ee024 into master Feb 14, 2025
125 of 126 checks passed
@epeartree epeartree deleted the 6714-unnecessary-resource-version-bump-on-update branch February 14, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary Resource version bump on update
2 participants