-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for case differences in DBPM contributor #6698
Account for case differences in DBPM contributor #6698
Conversation
Formatting check succeeded! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This passes all integration tests and smoke tests on hapi-fhir-jpaserver-starter.
However, there is an exception that appears during initialization.
To replicate, build hapi-fhir-jpaserver-starter, and then run it with the following command:
mvn -P jetty spring-boot:run
I can see the following in the startup log:
Error executing DDL "create index IDX_IDXCMPSTRUNIQ_RESOURCE on hfj_idx_cmp_string_uniq ()" via JDBC [Syntax error in SQL statement "create index IDX_IDXCMPSTRUNIQ_RESOURCE on hfj_idx_cmp_string_uniq ([*])"; expected "identifier";]
org.hibernate.tool.schema.spi.CommandAcceptanceException: Error executing DDL "create index IDX_IDXCMPSTRUNIQ_RESOURCE on hfj_idx_cmp_string_uniq ()" via JDBC [Syntax error in SQL statement "create index IDX_IDXCMPSTRUNIQ_RESOURCE on hfj_idx_cmp_string_uniq ([*])"; expected "identifier";]
This doesn't appear to be fatal, as the server still starts, and smoke tests run successfully, but there could be some other undiagnosed breakage that this causes.
...va/ca/uhn/hapi/fhir/sql/hibernatesvc/DatabasePartitionModeIdFilteringMappingContributor.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subsequent commits have fixed the exceptions on jpa startup. Looks good to me!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rel_8_0 #6698 +/- ##
==========================================
Coverage ? 83.59%
Complexity ? 28648
==========================================
Files ? 1798
Lines ? 111335
Branches ? 13979
==========================================
Hits ? 93068
Misses ? 12269
Partials ? 5998 ☔ View full report in Codecov by Sentry. |
This change fixes 2 regressions caused by Database Partitioning Mode:
insertable=false
which caused them to fail when used in non-DBPM mode.