Fix _security label filtering with :not operator in the in-memory matcher #6691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting check succeeded! |
nathandoef
changed the title
nathandoef
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rel_8_0 #6691 +/- ##
==========================================
Coverage ? 83.52%
Complexity ? 28606
==========================================
Files ? 1798
Lines ? 111311
Branches ? 13979
==========================================
Hits ? 92975
Misses ? 12347
Partials ? 5989 ☔ View full report in Codecov by Sentry. |
jmarchionatto
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the in-memory matcher was used to match resources with a
_securitylabel filterand a
:notoperator (i.e._security:not=http://terminology.hl7.org/CodeSystem/v3-ActCode|NODSCLCD), resources with no security labels at all were not matched. This has been fixed.