Fixing Failure when creating a cross-partition subscription if the default partition id is not null

[epeartree]

Background:

• The default value of the ID for the default partition is null;
• clients can provide another value for the default partition id through the partitionSettings.setDefaultPartitionId

Root cause of the issue:
invocation of RequestPartitionId.isDefaultParttition() only considers that the default partition id is and should be null;

What was done:

• added failing test;
• added api to an existing helper service to perform default partition check against the client configured defaultPartition Id (PartitionSettings);

Closes #6686

[github-actions]

Formatting check succeeded!

[TipzCM]

Request: can you put a logline in SubscriptionCanonicalizer to log something if no subscriptions match?

Just to make tracking bugs down here a bit easier next time?

[TipzCM]

Also, please add a log line in SubscriptionMatchingSubscriber so that when no subscriptions match, we have some loglines (warnings is my suggestion, but can ask in design)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (rel_8_0@ce0c41c). Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff             @@
##             rel_8_0    #6687   +/-   ##
==========================================
  Coverage           ?   83.59%           
  Complexity         ?    28647           
==========================================
  Files              ?     1798           
  Lines              ?   111328           
  Branches           ?    13979           
==========================================
  Hits               ?    93060           
  Misses             ?    12269           
  Partials           ?     5999           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.