Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6673 fixing search builder with fulltext search #6674

Merged
merged 13 commits into from
Feb 10, 2025

Conversation

TipzCM
Copy link
Collaborator

@TipzCM TipzCM commented Feb 3, 2025

closes #6673

Copy link

github-actions bot commented Feb 3, 2025

Formatting check succeeded!

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (rel_8_0@d9f86a9). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             rel_8_0    #6674   +/-   ##
==========================================
  Coverage           ?   83.59%           
  Complexity         ?    28635           
==========================================
  Files              ?     1798           
  Lines              ?   111323           
  Branches           ?    13978           
==========================================
  Hits               ?    93055           
  Misses             ?    12265           
  Partials           ?     6003           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jdar8 jdar8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question and suggested to fix 2 typos. Other than that, looks good. Will let someone else with approval power approve.

@TipzCM TipzCM enabled auto-merge (squash) February 10, 2025 15:40
@TipzCM TipzCM merged commit 65e4b13 into rel_8_0 Feb 10, 2025
66 of 67 checks passed
@TipzCM TipzCM deleted the 6673-fixing-search-builder-with-fulltext-search branch February 10, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants