Fixed an issue with the _lastUpdated search param not being recognised as a valid sort spec with Elastic Search enabled. #6670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting check succeeded! |
…d as a valid sort spec with Hsearch enabled in CDR
AbayomiE-T
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rel_8_0 #6670 +/- ##
==========================================
Coverage ? 83.58%
Complexity ? 28638
==========================================
Files ? 1798
Lines ? 111325
Branches ? 13979
==========================================
Hits ? 93052
Misses ? 12268
Partials ? 6005 ☔ View full report in Codecov by Sentry. |
epeartree
reviewed
Feb 3, 2025
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/search/HSearchSortHelperImpl.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/search/HSearchSortHelperImpl.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/search/HSearchSortHelperImpl.java
Outdated
Show resolved
Hide resolved
...-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/search/HSearchSortHelperImplTest.java
Outdated
Show resolved
Hide resolved
...-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/search/HSearchSortHelperImplTest.java
Outdated
Show resolved
Hide resolved
...-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/search/HSearchSortHelperImplTest.java
Show resolved
Hide resolved
...ver-test-r4/src/test/java/ca/uhn/fhir/jpa/provider/r4/TerminologyUploaderProviderR4Test.java
Show resolved
Hide resolved
added 4 commits
February 4, 2025 12:25
epeartree
reviewed
Feb 7, 2025
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/search/HSearchSortHelperImpl.java
Outdated
Show resolved
Hide resolved
epeartree
reviewed
Feb 7, 2025
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/search/HSearchSortHelperImpl.java
Show resolved
Hide resolved
...-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/search/HSearchSortHelperImplTest.java
Show resolved
Hide resolved
epeartree
reviewed
Feb 7, 2025
Right so I do have one on the CDR side but wasn't sure on how to go about the HAPI side since the bug was reported on CDR. Do I use the same ticket number for the .yaml file? Should it have the same content? |
AbayomiE-T
changed the title
epeartree
reviewed
Feb 10, 2025
...ources/ca/uhn/hapi/fhir/changelog/7_8_0/6697-missing-search-params-with-hsearch-enabled.yaml
Show resolved
Hide resolved
epeartree
reviewed
Feb 10, 2025
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/search/HSearchSortHelperImpl.java
Show resolved
Hide resolved
epeartree
reviewed
Feb 10, 2025
...-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/search/HSearchSortHelperImplTest.java
Outdated
Show resolved
Hide resolved
Addressed! |
epeartree
reviewed
Feb 10, 2025
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/search/HSearchSortHelperImpl.java
Outdated
Show resolved
Hide resolved
Done! |
epeartree
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With HSearch enabled and automatic support of default search params turned off, it is observed that a lot of search parameters are missing from the SearchParamRegistry which results in the error 500
HAPI-0389: Failed to call access method: org.springframework.dao.InvalidDataAccessApiUsageException:HAPI-2523: Invalid sort specification:_lastUpdatedwhen using the$apply-codesystem-delta-addoperation.A fall back was added in
HSearchSortHelperImpl.getParamType()to account for these missing search params.Closes #6697