Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added otel span for interceptors #5853

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

mrdnctrk
Copy link
Collaborator

@mrdnctrk mrdnctrk commented Apr 16, 2024

Added OpenTelemetry spans for the interceptor calls, with pointcut name, interceptor class name, and interceptor method names captured as span attribute
The span is name as "hapifhir.interceptor", and the attributes are
"hapifhir.interceptor.pointcut_name", "hapifhir.interceptor.class_name", "hapifhir.interceptor.method_name".

Added opentelemetry-instrumentation-annotations package as a global dependency so any package can use otel annotations like "WithSpan".

closes #5855

Copy link

Formatting check succeeded!

@mrdnctrk mrdnctrk force-pushed the add-interceptor-span branch 3 times, most recently from c204e43 to e9b4bd8 Compare April 17, 2024 15:49
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.38%. Comparing base (497b9f2) to head (e9b4bd8).
Report is 44 commits behind head on master.

❗ Current head e9b4bd8 differs from pull request most recent head 8482fb3. Consider uploading reports for the commit 8482fb3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5853      +/-   ##
============================================
- Coverage     83.39%   83.38%   -0.02%     
- Complexity    26927    26973      +46     
============================================
  Files          1681     1686       +5     
  Lines        103965   104135     +170     
  Branches      13189    13218      +29     
============================================
+ Hits          86702    86830     +128     
- Misses        11613    11661      +48     
+ Partials       5650     5644       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrdnctrk mrdnctrk force-pushed the add-interceptor-span branch from e9b4bd8 to e060028 Compare April 18, 2024 18:09
@michaelabuckley michaelabuckley enabled auto-merge (squash) April 18, 2024 18:45
@mrdnctrk mrdnctrk force-pushed the add-interceptor-span branch from e060028 to 1ac07d3 Compare April 19, 2024 12:08
@mrdnctrk mrdnctrk force-pushed the add-interceptor-span branch from 1ac07d3 to 8482fb3 Compare April 19, 2024 20:19
@michaelabuckley michaelabuckley merged commit 4125d8c into master Apr 19, 2024
64 of 65 checks passed
@michaelabuckley michaelabuckley deleted the add-interceptor-span branch April 19, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding opentelemetry spans for interceptor method calls
2 participants