Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: make it clear that functions accept unlimited number of parameters #1410

Merged
merged 6 commits into from
Jul 11, 2024

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Apr 30, 2024

Context

Internal discussion: https://handsoncode.slack.com/archives/C04MQ954YPL/p1713780506089739

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba self-assigned this Apr 30, 2024
@sequba sequba added the Docs Improvements or additions to documentation label Apr 30, 2024
Copy link

github-actions bot commented Apr 30, 2024

Performance comparison of head (1f16a5b) vs base (5485382)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 485.96 | 507.22 | +4.37%
                                      Sheet B | 152.98 | 165.82 | +8.39%
                                      Sheet T | 141.32 | 145.53 | +2.98%
                                Column ranges | 493.49 | 497.17 | +0.75%
Sheet A:  change value, add/remove row/column |   14.8 |  14.63 | -1.15%
 Sheet B: change value, add/remove row/column | 134.94 | 125.77 | -6.80%
                   Column ranges - add column | 147.13 | 140.87 | -4.25%
                Column ranges - without batch |  445.9 | 453.42 | +1.69%
                        Column ranges - batch |  122.8 | 130.58 | +6.34%

@sequba sequba marked this pull request as ready for review April 30, 2024 13:06
@sequba sequba requested a review from evanSe April 30, 2024 13:06
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (d7ee29f) to head (dc415f0).
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1410   +/-   ##
========================================
  Coverage    97.37%   97.37%           
========================================
  Files          169      169           
  Lines        14428    14428           
  Branches      3099     3099           
========================================
  Hits         14049    14049           
  Misses         376      376           
  Partials         3        3           

@sequba sequba merged commit 1701331 into develop Jul 11, 2024
18 of 20 checks passed
@sequba sequba deleted the feature/misleading-sum-description-in-the-docs branch July 11, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants