Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve editor's behavior while dataset altering #10963

Merged
merged 14 commits into from May 14, 2024
Merged

Conversation

budnix
Copy link
Member

@budnix budnix commented May 7, 2024

Context

The PR improves the editor's behavior in cases when the dataset is changed. The PR improves the following cases:

Update the editor position when the row (or column) is added above the cell

The editor is shifted down, and it's still opened and ready to continue typing the value. After approving the changes by hitting the Enter key, the value is applied to the correct cell.
Kapture 2024-05-13 at 12 46 28

Update the editor position when the row (or column) is removed above the cell

The editor is shifted up, and it's still opened and ready to continue typing the value. After approving the changes by hitting the Enter key, the value is applied to the correct cell.
Kapture 2024-05-13 at 12 49 13

Close the editor and revoke its value when the cell is deleted

Kapture 2024-05-13 at 12 50 08

Additionally, the PR improves the selection shift algorithm, which updates the selection position after removing or adding rows/columns.

How has this been tested?

I tested the changes locally, and I covered the feature with new tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/805

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this May 7, 2024
@budnix budnix changed the title Improve editor's behavior after dataset altering Improve editor's behavior while dataset altering May 9, 2024
Copy link

github-actions bot commented May 10, 2024

Launch the local version of documentation by running:

npm run docs:review b6e2ef11d2190629c88bbe898d17fad02aa38947

@budnix budnix marked this pull request as ready for review May 13, 2024 10:52
@budnix budnix requested a review from jansiegel May 13, 2024 10:52
@budnix budnix merged commit d3b83d5 into develop May 14, 2024
23 checks passed
@budnix budnix deleted the feature/dev-issue-805 branch May 14, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants