Improve editor's behavior while dataset altering #10963
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The PR improves the editor's behavior in cases when the dataset is changed. The PR improves the following cases:
Update the editor position when the row (or column) is added above the cell
The editor is shifted down, and it's still opened and ready to continue typing the value. After approving the changes by hitting the Enter key, the value is applied to the correct cell.
Update the editor position when the row (or column) is removed above the cell
The editor is shifted up, and it's still opened and ready to continue typing the value. After approving the changes by hitting the Enter key, the value is applied to the correct cell.
Close the editor and revoke its value when the cell is deleted
Additionally, the PR improves the selection shift algorithm, which updates the selection position after removing or adding rows/columns.
How has this been tested?
I tested the changes locally, and I covered the feature with new tests.
Types of changes
Related issue(s):
Affected project(s):
handsontable
Checklist: