Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataManager null errors #10914

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

aaronbeall
Copy link
Contributor

Context

In some cases after updating a table with nestedRows enabled, HoT would throw a null error due to trying to iterate over missing data that it assumed was there.

How has this been tested?

Manually tested to verify HoT null errors no longer occur from these places in my app.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@adrianszymanski89
Copy link
Contributor

adrianszymanski89 commented Apr 15, 2024

Hi @aaronbeall

Thank you very much for your contribution. We will review your PR and update you when we check if we can merge it.

Before that, please add a changelog entry and tests for the fix. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants