Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated demos to React 18 #10300

Closed
wants to merge 33 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
36b5e58
Update demo on handsontable.com/docs/react-data-grid/demo/ to use Rea…
wszymanski Mar 21, 2023
4d6074f
Fixed problem with one example from /react-data-grid/redux documentat…
wszymanski Mar 22, 2023
e77e14e
Changed examples which can be opened on JSFiddle
wszymanski Mar 22, 2023
2c83d17
Removed found unnecessary sign
wszymanski Mar 22, 2023
48cab3d
Updated dependencies to React 18
wszymanski Mar 22, 2023
cfb229a
Missing changes
wszymanski Mar 22, 2023
2ac85a3
Removed unnecessary change
wszymanski Mar 22, 2023
71426f1
WIP: Checking wheter fixed the problem
wszymanski Mar 23, 2023
6285e3f
Removed unnecessary change
wszymanski Mar 23, 2023
4f7a844
Merged with develop
wszymanski Mar 23, 2023
8c0aed0
Merge branch 'develop' into feature/dev-issue-1048
wszymanski Mar 24, 2023
41ebe0e
Updated TypeScript package version
wszymanski Mar 24, 2023
c66b37e
Reverted package update
wszymanski Mar 24, 2023
f9b3498
Fixed versions of updated packages as in the rest of examples
wszymanski Mar 24, 2023
2b36bdf
Fixed missed versions of packages - as in the rest of the project
wszymanski Mar 27, 2023
4450490
Updated wrapper types definition to 18.x
wszymanski Mar 27, 2023
9bf0a21
WIP: Updated package-lock.json after updating package.json file
wszymanski Mar 27, 2023
999afb1
Merge branch 'develop' into feature/dev-issue-1048
wszymanski Mar 27, 2023
c4a14ea
Reverted part of changes related to updating visual tests and example…
wszymanski Mar 27, 2023
8e49982
Merge branch 'feature/dev-issue-1048' of github.com:handsontable/hand…
wszymanski Mar 27, 2023
0a8612f
Missing change - once again
wszymanski Mar 27, 2023
903d64c
Merged with develop
wszymanski Jun 12, 2023
291d0c7
Merge branch 'develop' into feature/dev-issue-1048
wszymanski Jun 20, 2023
0a3d06e
Reverted part of changes related to updating examples (see my comment…
wszymanski Jun 20, 2023
437a449
Merge branch 'feature/dev-issue-1048' of github.com:handsontable/hand…
wszymanski Jun 20, 2023
f11a0ab
Upgraded wrapper dependencies to React 18 & updated examples
wszymanski Jul 6, 2023
6a05470
Missing change
wszymanski Jul 6, 2023
90b8dcf
Next package.json updates
wszymanski Jul 6, 2023
42b50f5
WIP: Not passing tests
wszymanski Jul 11, 2023
7ed57d6
Merge branch 'develop' into feature/dev-issue-1048
evanSe Feb 20, 2024
e57f18d
Fix build process
adrianspdev Feb 21, 2024
c29d766
Update root element id name
adrianspdev Feb 21, 2024
db873d6
Merge branch 'develop' into feature/dev-issue-1048
budnix Feb 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/.vuepress/handsontable-manager/dependencies.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ const buildDependencyGetter = (version) => {
fixer,
helpers,
hot: [getPackageUrls('handsontable', version, 'js'), ['Handsontable'], getPackageUrls('handsontable', version, 'css')],
react: ['https://cdn.jsdelivr.net/npm/react@17/umd/react.production.min.js', ['React']],
'react-dom': ['https://cdn.jsdelivr.net/npm/react-dom@17/umd/react-dom.production.min.js', ['ReactDOM']],
react: ['https://cdn.jsdelivr.net/npm/react@18/umd/react.production.min.js', ['React']],
'react-dom': ['https://cdn.jsdelivr.net/npm/react-dom@18/umd/react-dom.production.min.js', ['ReactDOM']],
'hot-react': [getPackageUrls('@handsontable/react', version, 'js'), ['Handsontable.react']],
'react-redux': ['https://cdnjs.cloudflare.com/ajax/libs/react-redux/7.2.4/react-redux.min.js'],
'react-colorful': ['https://cdn.jsdelivr.net/npm/[email protected]/dist/index.min.js'],
Expand Down
2 changes: 1 addition & 1 deletion docs/.vuepress/public/scripts/fixer.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
} else if (key === 'hyperformula') {
ns = 'HyperFormula';

} else if (key === 'react-dom') {
} else if (key === 'react-dom/client') {
ns = 'ReactDOM';

} else if (key === 'react-colorful') {
Expand Down
20 changes: 16 additions & 4 deletions docs/content/guides/accessories-and-menus/context-menu.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example1'));
const container = document.getElementById('example1');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -218,7 +221,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example2'));
const container = document.getElementById('example2');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -283,7 +289,10 @@ export const ExampleComponent = () => {
}

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example4'));
const container = document.getElementById('example4');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -503,7 +512,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example3'));
const container = document.getElementById('example3');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down
15 changes: 12 additions & 3 deletions docs/content/guides/accessories-and-menus/export-to-csv.md
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example1'));
const container = document.getElementById('example1');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -293,7 +296,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example2'));
const container = document.getElementById('example2');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -430,7 +436,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example3'));
const container = document.getElementById('example3');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down
5 changes: 4 additions & 1 deletion docs/content/guides/accessories-and-menus/undo-redo.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example'));
const container = document.getElementById('example');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down
10 changes: 8 additions & 2 deletions docs/content/guides/cell-features/autofill-values.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example1'));
const container = document.getElementById('example1');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -191,7 +194,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example2'));
const container = document.getElementById('example2');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down
15 changes: 12 additions & 3 deletions docs/content/guides/cell-features/clipboard.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example1'));
const container = document.getElementById('example1');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -286,7 +289,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example3'));
const container = document.getElementById('example3');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -403,7 +409,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example2'));
const container = document.getElementById('example2');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down
20 changes: 16 additions & 4 deletions docs/content/guides/cell-features/comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example1'));
const container = document.getElementById('example1');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -251,7 +254,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example2'));
const container = document.getElementById('example2');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -338,7 +344,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example3'));
const container = document.getElementById('example3');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -427,7 +436,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example4'));
const container = document.getElementById('example4');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down
5 changes: 4 additions & 1 deletion docs/content/guides/cell-features/conditional-formatting.md
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example1'));
const container = document.getElementById('example1');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down
20 changes: 16 additions & 4 deletions docs/content/guides/cell-features/disabled-cells.md
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example1'));
const container = document.getElementById('example1');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -306,7 +309,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example2'));
const container = document.getElementById('example2');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -417,7 +423,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example3'));
const container = document.getElementById('example3');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -526,7 +535,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example4'));
const container = document.getElementById('example4');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down
15 changes: 12 additions & 3 deletions docs/content/guides/cell-features/formatting-cells.md
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example1'));
const container = document.getElementById('example1');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -239,7 +242,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example2'));
const container = document.getElementById('example2');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -404,7 +410,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example3'));
const container = document.getElementById('example3');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down
5 changes: 4 additions & 1 deletion docs/content/guides/cell-features/merge-cells.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example1'));
const container = document.getElementById('example1');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down
15 changes: 12 additions & 3 deletions docs/content/guides/cell-features/selection.md
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example1'));
const container = document.getElementById('example1');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -321,7 +324,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example2'));
const container = document.getElementById('example2');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down Expand Up @@ -497,7 +503,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example3'));
const container = document.getElementById('example3');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down
5 changes: 4 additions & 1 deletion docs/content/guides/cell-features/text-alignment.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,10 @@ export const ExampleComponent = () => {
};

/* start:skip-in-preview */
ReactDOM.render(<ExampleComponent />, document.getElementById('example1'));
const container = document.getElementById('example1');
const root = ReactDOM.createRoot(container);

root.render(<ExampleComponent />);
/* end:skip-in-preview */
```

Expand Down