Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocFix: Conditional formatting sample is incorrect #10269

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

thilgen
Copy link

@thilgen thilgen commented Mar 8, 2023

Context

The embedded code sample for conditional formatting is incorrect on Conditional formatting - JavaScript Data Grid | Handsontable

Issue 1: The preview does not show the italic styling

image

Issue 2: When launching the sample into Fiddle (using the Edit button in the sample widget) neither the red or italic styling appear

image

How has this been tested?

Injected the updated sample code block into the webpage and launched Fiddle from Edit button

Note: I could not verify that the embedded preview in the sample widget on Conditional formatting - JavaScript Data Grid | Handsontable

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)
  • Doc change

Related issue(s):

  1. n/a

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@AMBudnik
Copy link
Contributor

Thank you for sharing the feedback. We already have this issue on the list. But I think that we'd prefer to keep the className and add it to the CSS section just as it was in the older version of this demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants