Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failure to create notification templates in themes #7199

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

guqing
Copy link
Member

@guqing guqing commented Jan 14, 2025

What type of PR is this?

/kind bug
/area core
/milestone 2.20.x

What this PR does / why we need it:

修复主题中声明的通知模板无法被创建的问题

Which issue(s) this PR fixes:

Fixes #7195

Does this PR introduce a user-facing change?

修复主题中声明的通知模板无法被创建的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jan 14, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Jan 14, 2025
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jan 14, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby January 14, 2025 04:31
Copy link

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 76.19048% with 10 lines in your changes missing coverage. Please review.

Project coverage is 57.23%. Comparing base (eff73dc) to head (490c25d).
Report is 86 commits behind head on main.

Files with missing lines Patch % Lines
...a/run/halo/app/theme/service/ThemeServiceImpl.java 76.19% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7199      +/-   ##
============================================
+ Coverage     56.99%   57.23%   +0.23%     
- Complexity     3999     4049      +50     
============================================
  Files           714      719       +5     
  Lines         24110    24383     +273     
  Branches       1585     1598      +13     
============================================
+ Hits          13742    13955     +213     
- Misses         9756     9810      +54     
- Partials        612      618       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
Copy link

f2c-ci-robot bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 3e3572e into halo-dev:main Jan 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

邮件通知提供自定义功能
2 participants