-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support hooking user creation #6945
Conversation
Signed-off-by: JohnNiang <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6945 +/- ##
============================================
+ Coverage 56.99% 57.23% +0.23%
- Complexity 3999 4005 +6
============================================
Files 714 712 -2
Lines 24110 24123 +13
Branches 1585 1588 +3
============================================
+ Hits 13742 13806 +64
+ Misses 9756 9704 -52
- Partials 612 613 +1 ☔ View full report in Codecov by Sentry. |
I'm going to merge this PR as quick as possible for a quick verification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area core
/milestone 2.20.x
What this PR does / why we need it:
This PR adds support for hooking user creating. Plugin developers can define extension points of
UserPreCreatingHandler
andUserPostCreatingHandler
to do something else.Does this PR introduce a user-facing change?