Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refine error message of the plugin already exists #5376

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 20, 2024

What type of PR is this?

/area core
/kind bug
/milestone 2.13.x

What this PR does / why we need it:

补全插件已存在错误提示的翻译。

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core release-note-none Denotes a PR that doesn't merit a release note. labels Feb 20, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.13.x milestone Feb 20, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen February 20, 2024 09:40
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 20, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fdf6c0) 56.91% compared to head (94a79a1) 56.90%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5376      +/-   ##
============================================
- Coverage     56.91%   56.90%   -0.01%     
+ Complexity     3319     3315       -4     
============================================
  Files           587      587              
  Lines         18968    18953      -15     
  Branches       1401     1399       -2     
============================================
- Hits          10795    10785      -10     
+ Misses         7594     7588       -6     
- Partials        579      580       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
Copy link

f2c-ci-robot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 50e954d into halo-dev:main Feb 20, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.13.x, 2.13.0 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants