Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Halo runtime environment to JRE 21 #5341

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Feb 6, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.13.x

What this PR does / why we need it:

Last month, Eclipse has released OpenJ9 0.42 supported Java 21. It's time for Halo to run JRE 21.

Closes #4929

Does this PR introduce a user-facing change?

升级 Docker 镜像的运行环境至 JRE 21。

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 6, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.13.x milestone Feb 6, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from lan-yonghui February 6, 2024 09:05
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Feb 6, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen February 6, 2024 09:05
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2cf19a4) 56.91% compared to head (5fdf6c0) 56.91%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5341   +/-   ##
=========================================
  Coverage     56.91%   56.91%           
  Complexity     3319     3319           
=========================================
  Files           587      587           
  Lines         18968    18968           
  Branches       1401     1401           
=========================================
  Hits          10795    10795           
  Misses         7594     7594           
  Partials        579      579           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnNiang
Copy link
Member Author

/ping @halo-dev/sig-halo

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2024
Copy link

f2c-ci-robot bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JohnNiang JohnNiang merged commit d2cee48 into halo-dev:main Feb 7, 2024
8 checks passed
@JohnNiang JohnNiang deleted the chore/upgrade-to-openj9-21 branch February 7, 2024 14:39
@ruibaby ruibaby modified the milestones: 2.13.x, 2.13.0 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JDK21支持
3 participants