-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-2.12] chore: remove unnecessary indices build process for lucene on startup #5333
[release-2.12] chore: remove unnecessary indices build process for lucene on startup #5333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
启动时刷新索引是非必要的。 |
Hi @Rainsheep ,目前文章的状态变更(如:发布->未发布,未发布->发布)是会调用扩展点的 |
@JohnNiang 用户在已有 Post 的前提下去安装 搜索类插件,必须手动刷新索引才能加载已发布的文章,增加了用户使用的复杂性,况且很多用户不知道刷新索引。 |
Hi @Rainsheep ,有道理。 不过建议重新创建 Issue 来跟进这个功能。 |
This is an automated cherry-pick of #5332
/assign guqing