Compatible with negative page number and size #5311
Conversation
f2c-ci-robot
bot
added
release-note
|
/cherrypick release-2.12 |
|
@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5311 +/- ##
============================================
+ Coverage 57.06% 57.11% +0.05%
- Complexity 3330 3334 +4
============================================
Files 587 587
Lines 18963 18965 +2
Branches 1402 1402
============================================
+ Hits 10821 10832 +11
+ Misses 7564 7555 -9
Partials 578 578 ☔ View full report in Codecov by Sentry. |
Signed-off-by: John Niang <[email protected]>
JohnNiang
force-pushed
the
bug/compatible-with-negative-page
branch
from
3fa058f to
58df1db
Compare
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
|
@JohnNiang: new pull request created: #5313 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #5311 /assign JohnNiang ```release-note 修复因限制分页参数导致部分主题页面无法正常渲染的问题。 ```
What type of PR is this?
/kind bug
/area core
/milestone 2.13.x
What this PR does / why we need it:
This PR makes Halo compatible with negative page number and size parameters to resolve #5298.
Which issue(s) this PR fixes:
Fixes #5298
Special notes for your reviewer:
Try to install Hao theme and Chirpy theme and check the frontend pages.
Does this PR introduce a user-facing change?