Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support building Docker image with major version tag #5304

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Support building Docker image with major version tag #5304

merged 1 commit into from
Feb 2, 2024

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind improvement
/area core
/milestone 2.13.x

What this PR does / why we need it:

This PR supports building Docker image with major version tag, e.g.: halohub/halo:2.

Which issue(s) this PR fixes:

Fixes #4976

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Feb 2, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.13.x milestone Feb 2, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Feb 2, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and LIlGG February 2, 2024 02:26
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

guqing
guqing reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2024
@JohnNiang
Copy link
Member Author

/cherry-pick release-2.12

@halo-dev-bot
Copy link
Collaborator

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ruibaby
ruibaby approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 27db40f into halo-dev:main Feb 2, 2024
8 checks passed
@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #5310

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@halo-dev-bot halo-dev-bot mentioned this pull request Feb 2, 2024
Merged
f2c-ci-robot bot pushed a commit that referenced this pull request Feb 2, 2024
@halo-dev-bot
[release-2.12] Support building Docker image with major version tag (#…
a1e1c91 
…5310)

This is an automated cherry-pick of #5304

/assign JohnNiang

```release-note
None
```
@JohnNiang JohnNiang deleted the chore/support-latest-tag-for-halo2 branch February 2, 2024 12:17
@ruibaby ruibaby modified the milestones: 2.13.x, 2.13.0 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@ruibaby ruibaby ruibaby approved these changes

@LIlGG LIlGG Awaiting requested review from LIlGG

Assignees

@ruibaby ruibaby

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

建议Docker仓库增加 halohub/halo:2 标签以方便升级
4 participants
@JohnNiang @halo-dev-bot @ruibaby @guqing