Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance additional web filter with scope and portal interception #5301

Closed
wants to merge 2 commits into from

Conversation

guqing
Copy link
Member

@guqing guqing commented Feb 1, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.13.x

What this PR does / why we need it:

增强 AdditionalWebFilter 扩展点支持 Scope 属性并支持拦截门户请求

Which issue(s) this PR fixes:

Fixes #5300

Does this PR introduce a user-facing change?

增强 AdditionalWebFilter 扩展点支持 Scope 属性并支持拦截门户请求

Copy link

f2c-ci-robot bot commented Feb 1, 2024

@guqing: The provided milestone is not valid for this repository. Milestones in this repository: [2.11.x, 2.12.0, 2.12.x, Backlog]

Use /milestone clear to clear the milestone.

In response to this:

What type of PR is this?

/kind improvement
/area core
/milestone 2.13.x

What this PR does / why we need it:

增强 AdditionalWebFilter 扩展点支持 Scope 属性并支持拦截门户请求

Which issue(s) this PR fixes:

Fixes #5300

Does this PR introduce a user-facing change?

增强 AdditionalWebFilter 扩展点支持 Scope 属性并支持拦截门户请求

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. area/core Issues or PRs related to the Halo Core labels Feb 1, 2024
Copy link

f2c-ci-robot bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from guqing. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (7341f9d) 56.91% compared to head (8c6f034) 56.90%.

Files Patch % Lines
...ava/run/halo/app/security/AdditionalWebFilter.java 0.00% 5 Missing ⚠️
...security/DynamicMatcherSecurityWebFilterChain.java 75.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5301      +/-   ##
============================================
- Coverage     56.91%   56.90%   -0.01%     
- Complexity     3319     3320       +1     
============================================
  Files           587      587              
  Lines         18968    18982      +14     
  Branches       1401     1403       +2     
============================================
+ Hits          10795    10802       +7     
- Misses         7594     7599       +5     
- Partials        579      581       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LIlGG LIlGG added this to the 2.13.x milestone Feb 1, 2024
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@guqing
Copy link
Member Author

guqing commented Feb 18, 2024

使用 #5349 代替

/close

@f2c-ci-robot f2c-ci-robot bot closed this Feb 18, 2024
Copy link

f2c-ci-robot bot commented Feb 18, 2024

@guqing: Closed this PR.

In response to this:

使用 #5349 代替

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby ruibaby modified the milestones: 2.13.x, 2.13.0 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

希望 AdditionalWebFilter 可以拦截门户请求
3 participants