-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit test errors on Windows environment #4842
Fix unit test errors on Windows environment #4842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ruibaby ,可能需要确认一下缺换至当前 PR 进行的测试。我发现一些测试用例错误,已经在当前 PR 修复过了。 |
![]() |
Codecov Report
@@ Coverage Diff @@
## main #4842 +/- ##
=========================================
Coverage 61.53% 61.54%
Complexity 2810 2810
=========================================
Files 406 406
Lines 14816 14819 +3
Branches 1030 1030
=========================================
+ Hits 9117 9120 +3
Misses 5203 5203
Partials 496 496
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/area core
What this PR does / why we need it:
This PR fixes the unit test errors on Windows environment, mainly caused by different file systems.
Does this PR introduce a user-facing change?