Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test errors on Windows environment #4842

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind cleanup
/area core

What this PR does / why we need it:

This PR fixes the unit test errors on Windows environment, mainly caused by different file systems.

PS C:\Users\johnniang\IdeaProjects\halo> ./gradlew check

> Task :application:checkstyleTest
Checkstyle rule violations were found. See the report at: file:///C:/Users/johnniang/IdeaProjects/halo/application/build/reports/checkstyle/test.html
Checkstyle files with violations: 16
Checkstyle violations by severity: [warning:43]


> Task :application:checkstyleMain
Checkstyle rule violations were found. See the report at: file:///C:/Users/johnniang/IdeaProjects/halo/application/build/reports/checkstyle/main.html
Checkstyle files with violations: 135
Checkstyle violations by severity: [warning:218]


> Task :application:test


BUILD SUCCESSFUL in 1m 39s
25 actionable tasks: 5 executed, 20 up-to-date

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. area/core Issues or PRs related to the Halo Core labels Nov 10, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from minliacom and ruibaby November 10, 2023 09:53
@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我使用 Windows 进行测试似乎还是有一些用例无法成功。

图片

测试报告:test.zip

@JohnNiang JohnNiang added this to the 2.11.x milestone Nov 12, 2023
@JohnNiang
Copy link
Member Author

Hi @ruibaby ,可能需要确认一下缺换至当前 PR 进行的测试。我发现一些测试用例错误,已经在当前 PR 修复过了。

@ruibaby
Copy link
Member

ruibaby commented Nov 12, 2023

Hi @ruibaby ,可能需要确认一下缺换至当前 PR 进行的测试。我发现一些测试用例错误,已经在当前 PR 修复过了。

图片

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #4842 (c2cfc0f) into main (4a6ce88) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #4842   +/-   ##
=========================================
  Coverage     61.53%   61.54%           
  Complexity     2810     2810           
=========================================
  Files           406      406           
  Lines         14816    14819    +3     
  Branches       1030     1030           
=========================================
+ Hits           9117     9120    +3     
  Misses         5203     5203           
  Partials        496      496           
Files Coverage Δ
...pp/core/extension/reconciler/PluginReconciler.java 54.12% <100.00%> (+0.29%) ⬆️

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
Copy link

f2c-ci-robot bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 7040299 into halo-dev:main Nov 13, 2023
@JohnNiang JohnNiang deleted the bug/ut-error-in-windows branch November 13, 2023 05:35
@ruibaby ruibaby modified the milestones: 2.11.x, 2.11.0 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants