-
Notifications
You must be signed in to change notification settings - Fork 256
[query] remove branchingFactor
from HailContext
#14963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ehigham
wants to merge
1
commit into
ehigham/optimiser-flags
Choose a base branch
from
ehigham/branching-factor-flags
base: ehigham/optimiser-flags
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
bb507e7
to
0bf6462
Compare
3adc65e
to
11403ed
Compare
0bf6462
to
969d3a0
Compare
2e67e7b
to
417e8a3
Compare
969d3a0
to
3c9e3ce
Compare
from
HailContext`branchingFactor
from HailContext
417e8a3
to
e739136
Compare
5e95ee0
to
3d6c841
Compare
2d38548
to
c3bb8a1
Compare
9873870
to
afe05c8
Compare
c3bb8a1
to
24a200f
Compare
afe05c8
to
d370b72
Compare
ae470ba
to
c164f2f
Compare
d370b72
to
5ce40c9
Compare
c164f2f
to
4538bfd
Compare
17d1b88
to
c6bdbe9
Compare
9d81d62
to
4f0cd2b
Compare
3eee0f5
to
7cca08e
Compare
4f0cd2b
to
c070764
Compare
7cca08e
to
ae46567
Compare
c070764
to
8834837
Compare
ae46567
to
008bd40
Compare
8834837
to
1eedaf6
Compare
1eedaf6
to
a4de72a
Compare
008bd40
to
0d67776
Compare
a4de72a
to
86a588b
Compare
0d67776
to
30456d7
Compare
86a588b
to
a6deb82
Compare
30456d7
to
5977e83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Refactored the branching factor parameter to be controlled through feature flags instead of being passed directly to the HailContext constructor. This change:
agg
package with utility functions to retrieve the branch factor from contextHailContext.get.branchingFactor
to useagg.branchFactor(ctx)
insteadThis approach provides a more consistent way to configure the branching factor through environment variables or programmatic flags, aligning with how other Hail parameters are managed.
Security Assessment
This change cannot impact the Hail Batch instance as deployed by Broad Institute in GCP