Added "My Clippings Path" preference to avoid having to find it manually each time #154
Conversation
|
Thanks for making this change. My original preference for solving this was not exposing the new "file location path" as a preference so users are not given too much complexity to configure and look for a pure UX solution. However, I think this is a good step to solving this problem in the immediate term. If you can just fix the linting issue, I'll happily merge. |
|
|
||
| private async myClippingsFileLocation(): void { | ||
| new Setting(this.containerEl) | ||
| .setName('My Clippings file location') |
There was a problem hiding this comment.
Would this preference make more sense if it was called "Default My Clippings file location"?
|
You will also need to manually bump the plugin version in order for it to be published as a new version. This needs to be done in |
|
@fkyuga I know you must be busy but do you plan on updating this PR? If not, I'd like to tackle this feature sometime |
|
@smarquez1 I originally wanted to give the PR's author the opportunity to contribute a change to the plugin so I haven't implemented this myself. I will likely fix this myself once I am done with a new major feature that I am working on. In the meantime, if you would like to have a go yourself, by all means go for it. It would be a positive change for the plugin |
|
This feature would be awesome. do you plan on updating this PR? |
|
Yeah I also wait for that feature, any updates? |
|
Agree, it would be a good feature. |
Simple patch for #150
This patch adds a new preference to the plugin allowing the user to enter the path to their Kindle's My Clippings.txt file:
The user initiates a sync like usual and chooses the "Upload My Clippings File" option. The plugin checks to see if the "My Clippings.txt" path is set in its settings and — if it is, the plugin continues using this file. If it isn't, or the plugin is unable to find a file at the specified path, a file open dialog is displayed as usual.