Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete rule DL3005 #964

Merged
merged 2 commits into from
Aug 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,6 @@ Please [create an issue][] if you have an idea for a good rule.
| [DL3002](https://github.com/hadolint/hadolint/wiki/DL3002) | Warning | Last user should not be root. |
| [DL3003](https://github.com/hadolint/hadolint/wiki/DL3003) | Warning | Use WORKDIR to switch to a directory. |
| [DL3004](https://github.com/hadolint/hadolint/wiki/DL3004) | Error | Do not use sudo as it leads to unpredictable behavior. Use a tool like gosu to enforce root. |
| [DL3005](https://github.com/hadolint/hadolint/wiki/DL3005) | Error | Do not use apt-get dist-upgrade. |
| [DL3006](https://github.com/hadolint/hadolint/wiki/DL3006) | Warning | Always tag the version of an image explicitly. |
| [DL3007](https://github.com/hadolint/hadolint/wiki/DL3007) | Warning | Using latest is prone to errors if the image will ever update. Pin the version explicitly to a release tag. |
| [DL3008](https://github.com/hadolint/hadolint/wiki/DL3008) | Warning | Pin versions in `apt-get install`. |
Expand Down
5 changes: 0 additions & 5 deletions contrib/hadolint.json
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,6 @@
"description": "Do not use sudo as it leads to unpredictable behavior. Use a tool like gosu to enforce root.",
"$comment": "https://github.com/hadolint/hadolint/wiki/DL3004"
},
{
"const": "DL3005",
"description": "Do not use apt-get upgrade or dist-upgrade.",
"$comment": "https://github.com/hadolint/hadolint/wiki/DL3005"
},
{
"const": "DL3006",
"description": "Always tag the version of an image explicitly.",
Expand Down
2 changes: 0 additions & 2 deletions hadolint.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ library
Hadolint.Rule.DL3002
Hadolint.Rule.DL3003
Hadolint.Rule.DL3004
Hadolint.Rule.DL3005
Hadolint.Rule.DL3006
Hadolint.Rule.DL3007
Hadolint.Rule.DL3008
Expand Down Expand Up @@ -226,7 +225,6 @@ test-suite hadolint-unit-tests
Hadolint.Rule.DL3002Spec
Hadolint.Rule.DL3003Spec
Hadolint.Rule.DL3004Spec
Hadolint.Rule.DL3005Spec
Hadolint.Rule.DL3006Spec
Hadolint.Rule.DL3007Spec
Hadolint.Rule.DL3008Spec
Expand Down
2 changes: 0 additions & 2 deletions src/Hadolint/Process.hs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import qualified Hadolint.Rule.DL3001
import qualified Hadolint.Rule.DL3002
import qualified Hadolint.Rule.DL3003
import qualified Hadolint.Rule.DL3004
import qualified Hadolint.Rule.DL3005
import qualified Hadolint.Rule.DL3006
import qualified Hadolint.Rule.DL3007
import qualified Hadolint.Rule.DL3008
Expand Down Expand Up @@ -120,7 +119,6 @@ failures Configuration {allowedRegistries, labelSchema, strictLabels} =
<> Hadolint.Rule.DL3002.rule
<> Hadolint.Rule.DL3003.rule
<> Hadolint.Rule.DL3004.rule
<> Hadolint.Rule.DL3005.rule
<> Hadolint.Rule.DL3006.rule
<> Hadolint.Rule.DL3007.rule
<> Hadolint.Rule.DL3008.rule
Expand Down
22 changes: 0 additions & 22 deletions src/Hadolint/Rule/DL3005.hs

This file was deleted.

15 changes: 0 additions & 15 deletions test/Hadolint/Rule/DL3005Spec.hs

This file was deleted.