Skip to content

Commit

Permalink
State the license in a way that GitHub recognizes (#882)
Browse files Browse the repository at this point in the history
  • Loading branch information
@jennybc
jennybc authored Nov 21, 2022
1 parent 52520dd commit 2ed752e
Showing 1 changed file with 402 additions and 1 deletion.
Loading

1 comment on commit 2ed752e

@jennybc
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This did not improve anything re: GitHub recognizing the license. We still have "Unknown, Unknown licenses found".

I guess this is because GitHub's approach to license recognition uses the Ruby gem https://github.com/licensee/licensee, which will only recognize open licences and CC-BY-NC-ND-4.0 is not regarded as such. So if you pick a license that's not on their list, GitHub says the license is "unknown" 😐

Relevant thread, because someone else here points out that this license is typically required by publishers:

licensee/licensee#116

I guess we just have to tolerate GitHub presenting the license as "unknown"?

More relevant links:

licensee/licensee#343

https://github.com/github/choosealicense.com/blob/gh-pages/CONTRIBUTING.md#adding-a-license

Please sign in to comment.