Auto-scheduled monthly announcement #10975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

garyhtou merged 39 commits into main from scheduled-announcements

Jul 21, 2025

Contributor

Luke-Oldenburg commented Jul 16, 2025 •

edited

Loading

Note

These announcements do not show up on the announcements overview until they are published or updated.

Luke-Oldenburg added 7 commits

July 16, 2025 20:13


          Add template column to announcement

21b483e


          Add monthly job

ba17c29


          Fix job class name

8f8d0bc


          Add monthly warning

d3668d6


          Add back frozen string literal

abbb5fa


          Discard other schema changes

01e5d93


          Update title for monthly

0f34cfb

Luke-Oldenburg marked this pull request as ready for review

July 16, 2025 20:58

Luke-Oldenburg requested review from a team as code owners

July 16, 2025 20:58

Luke-Oldenburg and others added 7 commits

July 16, 2025 20:59


          Use find_each

838ca03


          Merge branch 'main' into scheduled-announcements

227b9fa


          Rename column from template to template_type

385a337

I worked with Luke to rollback the old migration on his local dev, so hopefully we didn't mess up anyone's databases.


          Handle errors from publishing announcement

3a2b337


          [Announcement] Add Event::Config for generate_monthly_announcement

da1e8bd

This setting is not accessible for users just yet


          Make monthly job use generate_monthly_announcement

4cba20b


          Refactor warning email

2741dbd

garyhtou reviewed

View reviewed changes

app/jobs/announcement/monthly_warning_job.rb Outdated Show resolved Hide resolved

garyhtou reviewed

View reviewed changes

app/models/announcement.rb Show resolved Hide resolved

garyhtou reviewed

View reviewed changes

app/models/announcement/templates/blank.rb Outdated Show resolved Hide resolved

garyhtou reviewed

View reviewed changes

app/models/announcement/templates/monthly.rb Outdated Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

app/views/announcement_mailer/monthly_warning.html.erb Outdated Show resolved Hide resolved

app/views/announcement_mailer/monthly_warning.html.erb Outdated Show resolved Hide resolved

garyhtou reviewed

View reviewed changes

app/models/announcement/templates/monthly.rb Outdated Show resolved Hide resolved

garyhtou reviewed

View reviewed changes

app/views/announcement_mailer/monthly_warning.html.erb Outdated Show resolved Hide resolved

garyhtou reviewed

View reviewed changes

Member

garyhtou left a comment

reminder to self: Once merged do:

Event.find_each &:config

This will backfill events with config records.

Luke-Oldenburg and others added 5 commits

July 17, 2025 15:52


          Rename template to template_type

0cf7d19


          Update app/views/announcement_mailer/monthly_warning.html.erb

534e835

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          Use announcement created_at for donation summary

23a151d


          Rename monthly title

75ba96d


          Update app/views/announcement_mailer/monthly_warning.html.erb

330cdc7

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          class.name -> name

fce9a12

Luke-Oldenburg commented

View reviewed changes

app/models/announcement/templates/monthly.rb Outdated Show resolved Hide resolved

garyhtou reviewed

View reviewed changes

app/mailers/announcement_mailer.rb Outdated Show resolved Hide resolved

garyhtou and others added 3 commits

July 18, 2025 07:13


          Rename before action method

3e2bc57


          Use self.class.name instead of self.name

37646c5


          Revert "Delete monthly job"

51cd76d

This reverts commit 5b0b87c.

garyhtou reviewed

View reviewed changes

app/views/announcement_mailer/seven_day_warning.html.erb Show resolved Hide resolved

garyhtou reviewed

View reviewed changes

app/models/announcement/templates/monthly.rb Outdated Show resolved Hide resolved

Luke-Oldenburg added 2 commits

July 18, 2025 15:34


          Update mailer views

f468a6a


          Merge branch 'main' into scheduled-announcements

44ecabc

garyhtou requested changes

View reviewed changes

app/models/announcement/templates/monthly.rb Outdated Show resolved Hide resolved

app/views/announcement_mailer/seven_day_warning.html.erb Show resolved Hide resolved

garyhtou reviewed

View reviewed changes

Member

garyhtou left a comment

And let's add a toggle inside event settings for event.config.generate_monthly_announcement


          Update app/models/announcement/templates/monthly.rb

5a357a0

Co-authored-by: Gary Tou <[email protected]>

polypixeldev mentioned this pull request

Organization announcements hackclub/hcb-engr#94

Draft

Luke-Oldenburg added 11 commits

July 21, 2025 16:09


          Merge branch 'main' into scheduled-announcements

67142cb


          Merge branch 'main' into scheduled-announcements

1420c62


          Remove .to_json

4f70c1e


          Add explanation

64e43a6


          Merge branch 'main' into scheduled-announcements

1526f03


          Fix render code

e79bc27


          Add to params

d39fba3


          Add toggle

072639c


          after_initialize -> after_create

a25d4a6


          Fix monthly

8232f3f


          Move explanation

477dca8

garyhtou approved these changes

View reviewed changes

garyhtou added this pull request to the merge queue

Merged via the queue into main with commit 87bb1c5

12 checks passed

garyhtou deleted the scheduled-announcements branch

July 21, 2025 21:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet