block files larger than 25mb on comments #10894
Open
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Luke Oldenburg <[email protected]>
|
This is what I get after uploading too large of a file. |
garyhtou
requested changes
Jul 15, 2025
There was a problem hiding this comment.
Please use active_storage_validations to validate this!
https://github.com/igorkasyanchuk/active_storage_validations
Also, 25mb feels a bit small — we should determine what the 95 percentile is in prod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
comments on transactions allow you to upload almost any file, and any size, which is really bad for that aws bill
Describe your changes
this adds a simple limit to comment creations, checking the file size to not be larger than 25mb (which should be very generous for most peeps)