-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Changed the vulnerable versions of python dependencies of Tour app #2454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sulhicader. Please also go through all the examples that use these and make sure they still work. Include demo videos in this PR.
py/apps/tour/requirements.txt
Outdated
@@ -1,14 +1,14 @@ | |||
altair==4.2.0 | |||
bokeh==2.4.2 | |||
Faker==13.3.4 | |||
h2o-wave-ml==0.8.1 | |||
h2o-wave[ml]==1.6.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this version coming from? The last wave-ml version is 0.8.1 if I see correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this change to get the newer version of h2o3 (installed as its dependency). But it seems like newest version is installed even with h2o-wave-ml==0.8.1. So Don't need this change.
Examples which uses changed dependencies work fine. Deployed app instance - https://cloud-dev.h2o.dev/instance/c74b454a-f4bb-4b5c-906b-822a42df1ca7/ Demo Video -: Screen.Recording.2025-04-08.at.14.32.06.mov |
None of the examples in the video use the changed dependencies.
|
Here I added a new demo which compare the examples with the 1.5.1 version in internal dedicated Link to Demo -: https://drive.google.com/file/d/1cgq9OI3aA1a-hLJ9FwJu4RySpwUVzoV2/view?usp=drive_link Instance already has the All user visibility. If still face the problem You may try to start your own instance from here |
The PR fulfills these requirements: (check all the apply)
main
branch.feat: Add a button #xxx
, where "xxx" is the issue number).Closes #xxx
, where "xxx" is the issue number.ui
folder, unit tests (make test
) still pass.Closes #2453