[GH-3018] Add UpliftDRF #5698
[GH-3018] Add UpliftDRF #5698
Conversation
krasinski
requested review from
mn-mikke,
wendycwong,
tomasfryda,
valenad1,
maurever and
syzonyuliia
as code owners
| @@ -85,6 +85,11 @@ def testExtendedIsolationForestParameters(prostateDataset): | |||
| model = algorithm.fit(prostateDataset) | |||
| compareParameterValues(algorithm, model) | |||
|
|
|||
| def testExtendedIsolationForestParameters(prostateDataset): | |||
There was a problem hiding this comment.
This seems unrelated to UpliftDRF, so I suggest moving it to another task. :)
| @@ -97,6 +100,10 @@ class AlgorithmConfigurations extends MultipleAlgorithmsConfiguration { | |||
| val gamFields = Seq(ignoredCols, betaConstraints, gamCols) | |||
| val gbmFields = Seq(monotonicity, calibrationDataFrame, ignoredCols) | |||
| val drfFields = Seq(calibrationDataFrame, ignoredCols) | |||
| val upliftDrfFields = Seq( | |||
| ExplicitField("treatment_column", "HasTreatmentCol", "treatment"), | |||
| ExplicitField("response_column", "HasLabelCol", "label"), | |||
There was a problem hiding this comment.
Why do we need to specify label column explicitly? Isn't uplift DRF just another supervised algorithm?
There was a problem hiding this comment.
The response column is used the same way as in the supervised algorithm.
| @@ -97,6 +100,10 @@ class AlgorithmConfigurations extends MultipleAlgorithmsConfiguration { | |||
| val gamFields = Seq(ignoredCols, betaConstraints, gamCols) | |||
| val gbmFields = Seq(monotonicity, calibrationDataFrame, ignoredCols) | |||
| val drfFields = Seq(calibrationDataFrame, ignoredCols) | |||
| val upliftDrfFields = Seq( | |||
| ExplicitField("treatment_column", "HasTreatmentCol", "treatment"), | |||
There was a problem hiding this comment.
Why do we need an explicit field for treatment? Could we just add another rule to ParameterNameConverter?
There was a problem hiding this comment.
Yes, for the uplift algorithm, the new treatment column is crucial. However I am not sure how this algorithm configuration works, so I am not sure if this is the correct way to add the treatment column.
No description provided.