Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HF Data import #793

Merged
merged 7 commits into from
Jul 31, 2024
Merged

HF Data import #793

merged 7 commits into from
Jul 31, 2024

Conversation

psinger
Copy link
Collaborator

@psinger psinger commented Jul 30, 2024

For now, just imports the dataset with a given split, transforms to pandas.

To make this even more useful, need to support #792

Closes #335

@psinger psinger requested a review from pascal-pfeiffer as a code owner July 30, 2024 15:18
Copy link
Collaborator

@pascal-pfeiffer pascal-pfeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super helpful and works great, thank you!

Can we make sure that the user is logged in for the operation? I think right now it only works when another operation called the huggingface hub login at least once before. While allowing to set defaults in the settings, we should also show the HF token in the import menu and allow changes to align with the other import options (S3, kaggle)

@psinger psinger requested a review from pascal-pfeiffer July 31, 2024 10:02
Copy link
Collaborator

@pascal-pfeiffer pascal-pfeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nits, otherwise lgtm! Thank you again.

@psinger psinger requested a review from sherenem as a code owner July 31, 2024 11:51
@psinger psinger merged commit aa2c210 into main Jul 31, 2024
4 checks passed
@pascal-pfeiffer pascal-pfeiffer deleted the psi/hf_import branch July 31, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CODE IMPROVEMENT] Import dataset from Hugging Face
2 participants