Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-15535] Python 3.11 support #15781

Merged
merged 14 commits into from
Oct 3, 2023
Merged

[GH-15535] Python 3.11 support #15781

merged 14 commits into from
Oct 3, 2023

Conversation

mn-mikke
Copy link
Collaborator

@mn-mikke mn-mikke commented Sep 25, 2023

closes #15535

As part of this PR, there are new testing images:

harbor.h2o.ai/opsh2oai/h2o-3/dev-python-3.11:42
harbor.h2o.ai/opsh2oai/h2o-3/dev-python-3.11-jdk-8:42
harbor.h2o.ai/opsh2oai/h2o-3/dev-python-3.11-jdk-11:42
harbor.h2o.ai/opsh2oai/h2o-3/dev-python-3.11-jdk-17:42

This pr also moves al python small stages to PR tests (PR test are also a part of nightly).

@mn-mikke mn-mikke marked this pull request as ready for review October 2, 2023 11:51
valenad1
valenad1 previously approved these changes Oct 2, 2023
Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions ❓

Looks good to me, thank you!

@@ -35,7 +36,7 @@ lifelines>=0.19.5
xlsxwriter==1.3.7
xgboost==1.7.6
causalml==0.12.3; python_version <= '3.7'
causalml==0.14.1; python_version > '3.7'
causalml==0.14.1; python_version > '3.7' and python_version < '3.11'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be:

and python_version <= '3.11'

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, causalml doesn't support python 3.11 yet.

@mn-mikke mn-mikke merged commit 3459e78 into master Oct 3, 2023
2 checks passed
@mn-mikke mn-mikke deleted the mn/GH-15535 branch October 3, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Python 3.10 and 3.11 in H2O Packages
3 participants